neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16258 )
Change subject: D-GSM 3/n: implement roaming by mslookup in osmo-hlr ...................................................................... Patch Set 16: (2 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/16258/15/src/mslookup_server_mdns.c File src/mslookup_server_mdns.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16258/15/src/mslookup_server_mdns.c@130 PS15, Line 130: should_run = g_hlr->mslookup.allow_startup > This looks like a fix from code belonging to a previous patch? Done https://gerrit.osmocom.org/c/osmo-hlr/+/16258/15/tests/test_nodes.vty File tests/test_nodes.vty: https://gerrit.osmocom.org/c/osmo-hlr/+/16258/15/tests/test_nodes.vty@403 PS15, Line 403: mdns to 239.192.23.42 4266 > This "to" should be removed from VTY too. See for instance above "mdns bind > 239.192.23.42 4266". […] we allow multiple binds on the same IP and port, and each client and server all bind to the same multicast IP and port. (every program also receives their own sent data and ignores.) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I2fe453553c90e6ee527ed13a13089900efd488aa Gerrit-Change-Number: 16258 Gerrit-PatchSet: 16 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Thu, 09 Jan 2020 17:53:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
