Dne 19.12.2010 17:10, Miroslav Šulc napsal(a): > Dne 19.12.2010 15:26, Julien Hardelin napsal(a): >>> i have 10 patches in my local git repo now fixing various problems, and >>> now even in the proper format. i just did not want to spam bugzilla more. >> Hi Miroslav, >> >> I'll take care of your patches in Bugzilla. >> >> In magnify_to_zoom.patch, there are changes in po of different >> languages. Usually, patches are only for source xml files. >> >> I am not sure translators will agree foreign changes in their work. >> >> I'll apply only changes in source xml files. > cool, thanks. i have more patches on my disk, and planning to make a > patch for other stuff too, like the capitalization of titles (and > uncapitalization of image labels), tagging ui objects etc ... just need > to know what is supposed to be the right style for the docs as it is not > obvious to me yet. > > also, i agree with you that the fixes should probably be done only in > src dir, the translation teams will get them once they update their po > files as it affects also msgid items. i have no idea how much it will > break their work as the msgid values will be new and will not match what > comes from the main xml files. from this point of view patching also > msgid lines would be better, but it's a question whether some inner po > logic will not be broken by that. > > up to that, the changes are just in english language, so it affects > either the untranslated texts or the msgid lines, not their translations. just as thinking about it, please let me know what way you wanna apply the patches. if you wanna change just src files, i can adjust the patches. i used mostly grep and sed for these patches so they were fast to create, but there were also cases with one line ending with "the" and following line beginning with "the" so some changes were not that trivial.
also, as these issues occur both in gimp-help-2-6-0 and in master, in my opinion they should go first to branch gimp-help-2-6-0 and then should be merged to master (and after that master should be searched for any ommitted cases), but i noticed there is quite a lot (exactly 9) unmerged changes between gimp-help-2-6-0 and master so i am not sure you port everything from 2.6 branch to master. up to that, some changes, though not merged from the branch, are in the master anyway, which confuses me even more :-) after this, i can adjust the patches and prepare the rest of patches (i have total 10, just 6 are at bugzilla atm) and i will know how to prepare the rest. >> Your new look at GIMP Help is precious. >> >> All the best, >> >> Julien miroslav _______________________________________________ Gimp-docs mailing list Gimp-docs@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-docs