[ 
https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153646#comment-13153646
 ] 

jirapos...@reviews.apache.org commented on GIRAPH-84:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2885/
-----------------------------------------------------------

Review request for giraph.


Summary
-------

Simplifying boolean expression using ternary operation.


This addresses bug GIRAPH-84.
    https://issues.apache.org/jira/browse/GIRAPH-84


Diffs
-----

  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/BspRecordReader.java
 1204113 

Diff: https://reviews.apache.org/r/2885/diff


Testing
-------

$ mvn test


Thanks,

shaunak


                
> Simplify boolean expressions in BspRecordReader
> -----------------------------------------------
>
>                 Key: GIRAPH-84
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-84
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Assignee: Shaunak Kashyap
>              Labels: newbie
>
> Twice in BspRecordReader boolean expressions are evaluated with == and can be 
> simplified to just one liners or variable evaluation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to