Claudio Martella commented on GIRAPH-84:

One more thing, the descriptions mentions two places where the expression could 
be simplified, you're missing the nextKeyValue() method. You may want to 
express it with something like:

return (seenRecord == false ? seenRecord = true : false);

Also, what about using a static final Text ONLY_KEY = Text("only key")? instead 
of creating multiple objects?
> Simplify boolean expressions in BspRecordReader
> -----------------------------------------------
>                 Key: GIRAPH-84
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-84
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Assignee: Shaunak Kashyap
>              Labels: newbie
> Twice in BspRecordReader boolean expressions are evaluated with == and can be 
> simplified to just one liners or variable evaluation.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to