[
https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153870#comment-13153870
]
[email protected] commented on GIRAPH-84:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2885/#review3375
-----------------------------------------------------------
Ship it!
Yep, looks good to me. Note to committers: how does it work in these
situations? Shall I just commit this or should I +1 and wait for another one?
- Claudio
On 2011-11-20 02:40:35, shaunak wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2885/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-20 02:40:35)
bq.
bq.
bq. Review request for giraph.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Simplifying boolean expression using ternary operation.
bq.
bq.
bq. This addresses bug GIRAPH-84.
bq. https://issues.apache.org/jira/browse/GIRAPH-84
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/BspRecordReader.java
1204113
bq.
bq. Diff: https://reviews.apache.org/r/2885/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. $ mvn test
bq.
bq.
bq. Thanks,
bq.
bq. shaunak
bq.
bq.
> Simplify boolean expressions in BspRecordReader
> -----------------------------------------------
>
> Key: GIRAPH-84
> URL: https://issues.apache.org/jira/browse/GIRAPH-84
> Project: Giraph
> Issue Type: Improvement
> Reporter: Jakob Homan
> Assignee: Shaunak Kashyap
> Labels: newbie
>
> Twice in BspRecordReader boolean expressions are evaluated with == and can be
> simplified to just one liners or variable evaluation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
