On Mon, 11 Jul 2005, Eric W. Biederman wrote:
> A couple of pieces.  The dist target has assumes git-tar-tree is in the
> path.  Making it so you have to have git installed to build the rpm.

Yes. Maybe we could relax that requirement by using "./git-tar-tree" or 
something? That still requires that you have _built_ git to do the rpm, 
but at least you won't have had to install it.

Does that fit the rpm build process? Or does an rpm build make something 
like that really inconvenient? I don't know, patches welcome.

> The man pages are not built. The build dependencies do not call out
> the tools necessary to build the man pages.

Most people don't have asciidoc, and I'm not sure we want to require it. 
Maybe we could have a separate "make man-rpm" target for that?

> And it does not pass my torture test of building rpm's on debian,
> but that is not a huge problem.

Ok, why is debian problematic? Is there some missing dependency or 
something? I really haven't ever done an rpm, and the git rpm target was 
all done by Chris Wright, so I don't have any clue at all. Again, patches 

> Are you still up for a patch that records who and when made a tag?
> I sent one but it seems to have been lost.

I'd really actually prefer for the code to be shared with the commit code, 
so that the user info (name, email, date) would not just be exactly the 
same, but would share the same code so that we don't end up having them 
ever get out of sync. 

That would imply moving parts of "git-tag-script" into mktag.c.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to