It appears that gitk gets wider test coverage only after it is
pulled into git.git repository. I think it would be a good idea
for me to pull from you often.
Recently there was a discussion with binary packaging folks.
While I do not mind, and actually I would prefer, shipping gitk
as part of the core GIT, I have never heard about your
preference. As long as gitk is just a single file (or even a
handful files in the future) project that does not have a
filename that overlaps with core GIT, I can continue pulling
from you and I think the binary packaging folks can produce
separate git-core and gitk package out of git.git tree without
problems. However, once you start wanting to have your own
Makefile and maybe debian/rules file for packaging, for example,
I suspect the way currently things are set up would break
miserably. It's all Linus' fault to have merged with your tree
in the first place ;-).
Anyhow, I have one bug to report. I selected one rev, and then
said "diff this -> selected" from right-click menu on an
adjacent one, and I got this:
wrong # args: should be "startdiff ids"
wrong # args: should be "startdiff ids"
while executing
"startdiff $newid [list $oldid]"
(procedure "diffvssel" line 28)
invoked from within
"diffvssel 0"
invoked from within
".rowctxmenu invoke active"
("uplevel" body line 1)
invoked from within
"uplevel #0 [list $w invoke active]"
(procedure "tk::MenuInvoke" line 47)
invoked from within
"tk::MenuInvoke .rowctxmenu 1"
(command bound to event)
The following seems to fix it.
------------
Fix diff invoked from the right-click menu.
Signed-off-by: Junio C Hamano <[EMAIL PROTECTED]>
---
# - master: [PATCH] Making it easier to find which change introduced a bug
# + (working tree)
diff --git a/gitk b/gitk
--- a/gitk
+++ b/gitk
@@ -2700,7 +2700,7 @@ proc diffvssel {dirn} {
$ctext conf -state disabled
$ctext tag delete Comments
$ctext tag remove found 1.0 end
- startdiff $newid [list $oldid]
+ startdiff [list $newid $oldid]
}
proc mkpatch {} {
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
