On Tue, Mar 12, 2013 at 05:16:20PM +0100, Heiko Voigt wrote: > > Ok if you say so I will do that :-). I was thinking about adding a patch > > that would remove cf as a global variable and explicitely pass it down > > to get_next_char. That makes it more obvious that it actually is != NULL. > > Looking at your callgraph I do not think its that much work. What do you > > think? > > I just had a look and unfortunately there are other functions that use > this variable (namely handle_path_include) for which its not that easy > to pass this in. So I will just drop the check here.
Ah, I should have read all your responses before answering the last email. I think handle_path_include is surmountable, and I started to do a proof-of-concept patch, but there's a harder one: die_bad_config, which is called from git_config_int and friends. Getting the "cf" pointer there is hard, because you would have to update every config callback that uses git_config_int. Not worth it, I think. Thanks for looking, though. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
