On Mon, Jul 1, 2013 at 1:00 PM, Junio C Hamano <gits...@pobox.com> wrote:
> Eric Sunshine <sunsh...@sunshineco.com> writes:
>> No attempt is made to answer Junio's v9 review, as I lack sufficient
>> insight with '-C' options to be able to respond properly.
> I just wanted to see if we want to allow the end user of this script
> to specify what -C level they want the underlying blame to use, or
> just a hardcoded one should suffice (and if so an explanation why).
It might indeed make sense to allow the user control over the -C
level, just as the user likely should have control over other
assumptions made by the script (to wit: $since = '5-years-ago';
$min_percent = 10). More fodder for future patches.
Now that I've read up more carefully on the -C option, I too wonder
why git-blame and git-show are invoked with different -C levels. At
the very least, I think they should be unified in this initial patch
to either one or two -C's. Since the script already is quite slow, I'm
leaning toward just one -C.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html