Stefan Beller <> writes:

> On 08/21/2013 10:49 AM, Matthieu Moy wrote:
>>> +   if (start_command(&cmd))
>>> > +         return 1;
>> A warning message would be welcome in addition to returning 1.
> Johannes Sixt proposes to retain the return value of
> the sub process, which I'd agree on.


> I'd expect the pack-objects to bring up the warning as
> the stderr is untouched in the command invocation.

I was more thinking of weird cases like failure to fork or so. But
according to api-run-command.txt:

  . If a system call failed, errno is set and -1 is returned. A diagnostic
    is printed.

So you actually don't need it. In this case, following Johannes's
suggestion, you'd return -1 from the main function, which is unusual but

Matthieu Moy
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to