On Sat, Mar 22, 2014 at 4:31 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Chris Angelico <ros...@gmail.com> writes:
>> On Fri, Mar 21, 2014 at 2:43 PM, Jeff King <p...@peff.net> wrote:
>>> Thanks, the new text looks good to me. Please follow SubmittingPatches
>>> (notably, you need to sign-off your work, and please send patches inline
>>> rather than as attachments).
>> Ah, didn't see that file.
> It appears that we might need to be more explicit in that file,
> though.
> [chomp specifics]

Please do. I read through the file as a set of instructions, and would
have followed them if they'd been there. Fitting into a project like
that is what those sorts of guides are for.

> Also I'd title the commit with the area it touches, i.e. starting it
> with "Explain blah" is suboptimal.

Interestingly, this is exactly what my hook is for! It searches for
previous commits touching that file, looks for something separated off
by a colon, and pre-fills the commit message with that. (If there are
multiple options, they're all listed, commented out. Otherwise, it's
put in without a leading hash, so I just hit the End key - I use nano
for commit messages - and start typing.)

> Will queue with a minor tweak, with retitling the change and
> rephrasing the "ideally" part, which invites people to say "well it
> may be so in the ideal world but the rule does not apply to me".

Awesome. I tried to keep it brief (and the "ideally" was from the
point of view of someone trying to configure someone else's tool), but
explicitly talking about creating new variables makes that even
clearer. Thanks.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to