On Wed, 28 May 2014 15:31:13 -0700 Junio C Hamano <gits...@pobox.com> wrote:

> The latest feature release Git v2.0.0 is now available at the
> usual places.

> "git request-pull" lost a few "heuristics" that often led to mistakes.

I've installed git 2.0.0 and now when I

  git request-pull master git://neil.brown.name/md

after tagging the current commit as "md/3.15-fixes" and pushing out the tag,
I get

warn: No match for commit 2ac295a544dcae9299cba13ce250419117ae7fd1 found at 
warn: Are you sure you pushed 'HEAD' there?

   git ls-remote git://neil.brown.name/md | grep 2ac29

2ac295a544dcae9299cba13ce250419117ae7fd1        refs/tags/md/3.15-fixes^{}

Which seems clear and unambiguous.

Does this mean that the 'end' arg to 'git request-pull' is no longer optional
(i.e. the man page is wrong), or that too many heuristics were removed?

.... Looking through the change log a bit, it seems that if the 'end' arg is
omitted, then the current 'branch' name is used and must match the same name
at the git URL.  Could it also check the current 'tag' name?  As we are
encouraged to used signed tags, this seems sensible.
In fact, I would suggest checking for a tag first, and only considering the
branch name if there is no tag on the current commit.


Attachment: signature.asc
Description: PGP signature

Reply via email to