ryan-highley commented on code in PR #4122:
URL: https://github.com/apache/activemq-artemis/pull/4122#discussion_r911073599
##########
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##########
@@ -16,18 +16,23 @@
limitations under the License.
Review Comment:
The intent of the changes is to remove all the embedded {{element}} and
{{complexType}} definitions from the {{core}} definition.
By moving these schema definitions, XML tooling becomes valid for both
included XML elements and the overall {{broker.xml}} file. As with the
{{diverts}} example in the JIRA (not mine--just trying to address it), an IDE
has no idea what a {{diverts}} is outside of a {{core}} element, meaning syntax
help is not available. Any other valid imported element file, e.g. included
files containing top-level {{addresses}}, {{connectors}}, {{acceptors}}, etc.
elements, would also have the same syntax tooling support.
As you mentioned, XML includes work just fine currently, but the schema
definition as it currently stands does not support included element files as
well as it can and should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
