michaelpearce-gain commented on code in PR #4122: URL: https://github.com/apache/activemq-artemis/pull/4122#discussion_r911147124
########## artemis-server/src/main/resources/schema/artemis-configuration.xsd: ########## @@ -16,18 +16,23 @@ limitations under the License. --> <xsd:schema xmlns:xsd="http://www.w3.org/2001/XMLSchema"; + xmlns:xi="http://www.w3.org/2001/XInclude"; xmlns="urn:activemq:core" targetNamespace="urn:activemq:core" attributeFormDefault="unqualified" elementFormDefault="qualified" version="1.0"> <xsd:import namespace="http://www.w3.org/XML/1998/namespace"; schemaLocation="xml.xsd"/> + <xsd:import namespace="http://www.w3.org/2001/XInclude"; schemaLocation="XInclude.xsd"/> <xsd:element name="core" type="configurationType"/> <xsd:complexType name="configurationType"> <xsd:all> + + <xsd:element ref="xi:include" maxOccurs="1" minOccurs="0"/> Review Comment: Against the jira thats linked here the need is to have divert in an external config file imported.... this is possible today without these mass changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
