ryan-highley commented on code in PR #4122: URL: https://github.com/apache/activemq-artemis/pull/4122#discussion_r911084581
########## artemis-server/src/main/resources/schema/artemis-configuration.xsd: ########## @@ -16,18 +16,23 @@ limitations under the License. --> <xsd:schema xmlns:xsd="http://www.w3.org/2001/XMLSchema"; + xmlns:xi="http://www.w3.org/2001/XInclude"; xmlns="urn:activemq:core" targetNamespace="urn:activemq:core" attributeFormDefault="unqualified" elementFormDefault="qualified" version="1.0"> <xsd:import namespace="http://www.w3.org/XML/1998/namespace"; schemaLocation="xml.xsd"/> + <xsd:import namespace="http://www.w3.org/2001/XInclude"; schemaLocation="XInclude.xsd"/> <xsd:element name="core" type="configurationType"/> <xsd:complexType name="configurationType"> <xsd:all> + + <xsd:element ref="xi:include" maxOccurs="1" minOccurs="0"/> Review Comment: {{<xi:include>}} is not currently a valid element in {{configurationType}}, leading syntax validation tooling to balk. Including this element ref is the reason for adding the XInclude.xsd file. XSD 1.0 only allows {{all}} groups to have {{minOccurs == 0}} and {{maxOccurs == 1}}, while valid configurations of course could have multiple included element files. XSD 1.1 drops this restriction but including an XSD 1.1 validator turned out to be exceedingly painful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
