michaelandrepearce commented on code in PR #4122: URL: https://github.com/apache/activemq-artemis/pull/4122#discussion_r911224533
########## artemis-server/src/main/resources/schema/artemis-configuration.xsd: ########## @@ -16,18 +16,23 @@ limitations under the License. Review Comment: As i said, if theres a specific, area that needs to change (e.g. a particular section isn't importable but is sensible to extract) great, im happy to help focus to address the point area, but as it stands and as a project maintainer (pmc) i don't feel that comfortable with this change the risk is very large and i don't feel is needed personally. If other maintainers (pmc or committers) wish to jump in here, and feel very confident about the change not breaking anyone's setups then great. Though the fact existing configs for tests is needed to be changed to support the change, suggests this change is a break change. The change should not require any existing tests or configs to have change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
