andytaylor commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r993260431


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/AbstractControl.java:
##########
@@ -50,8 +51,15 @@ public AbstractControl(final Class<?> clazz, final 
StorageManager storageManager
       this.storageManager = storageManager;
    }
 
+   public long getLastDeliveredTimeElapsed(ServerConsumer consumer) {
+      long currentTime = System.currentTimeMillis();
+      return consumer.getLastDeliveredTime() == 0 ? 0 : currentTime - 
consumer.getLastDeliveredTime();

Review Comment:
   Ive reverted to just passing back the current time as per @gtully suggested



##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java:
##########
@@ -506,8 +510,10 @@ public void proceedDeliver(MessageReference reference) 
throws Exception {
             // The deliverer was prepared during handle, as we can't have more 
than one pending large message
             // as it would return busy if there is anything pending
             largeMessageDeliverer.deliver();
+            //lastDeliveredTime = System.currentTimeMillis();

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to