andytaylor commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r995648395
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java:
##########
@@ -2342,8 +2331,8 @@ public Pair<SimpleString, EnumSet<RoutingType>>
getAddressAndRoutingTypes(Simple
@Override
public void addProducer(ServerProducer serverProducer) {
serverProducer.setSessionID(getName());
- serverProducer.setConnectionID(getConnectionID().toString());
- producers.put(serverProducer.getID(), serverProducer);
+ serverProducer.setConnectionID(getConnectionID() != null ?
getConnectionID().toString() : null);
+ producers.put(serverProducer.getAddress(), serverProducer);
Review Comment:
Ive updated the addProducer to take the address so its always correct, Ive
also removed the removeproducer below and now use a cllback to remove the
producer only if its an FQQm and the queue is removed. I have also added tests
for FQQN, JMS (core and AMQP) forr queues, topics and anon producers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
