gemmellr commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r995626552


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java:
##########
@@ -1185,7 +1182,7 @@ public void deleteQueue(final SimpleString queueToDelete) 
throws Exception {
       }
 
       if (server.getAddressInfo(unPrefixedQueueName) == null) {
-         targetAddressInfos.remove(queueToDelete);
+         producers.remove(queueToDelete.toString());

Review Comment:
   > Actually the only time it needs removing is when it is an FQQN, if a 
producer is sending just to an address it doesnt matter if any of its queues is 
deleted as in the subscription case. 
   
   Ah I guess, so the thinking is it will just try removing something that 
never actually existed in the sub case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to