gemmellr commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r995636414
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java:
##########
@@ -704,9 +708,9 @@ public List<MessageReference> cancelRefs(final boolean
failed,
final List<MessageReference> refs = new
ArrayList<>(deliveringRefs.size());
MessageReference ref;
while ((ref = deliveringRefs.poll()) != null) {
+ metrics.addAcknowledge(ref.getMessage().getEncodeSize());
Review Comment:
The others dont all seem to be synchronized on lock, e.g. the
ServerConsumerImpl#acknowledge and ServerConsumerImpl#individualAcknowledge
dont look to be when they are calling the same method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
