andytaylor commented on code in PR #4183:
URL: https://github.com/apache/activemq-artemis/pull/4183#discussion_r995649155
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java:
##########
@@ -2769,27 +2775,554 @@ public void testListAllConsumersAsJSON() throws
Exception {
JsonObject first = sorted[0];
JsonObject second = sorted[1];
- Assert.assertTrue(first.getJsonNumber("creationTime").longValue() > 0);
- Assert.assertNotNull(first.getJsonNumber("consumerID").longValue());
- Assert.assertTrue(first.getString("connectionID").length() > 0);
- Assert.assertEquals(factory.getConnection().getID().toString(),
first.getString("connectionID"));
- Assert.assertTrue(first.getString("sessionID").length() > 0);
- Assert.assertEquals(((ClientSessionImpl) session).getName(),
first.getString("sessionID"));
- Assert.assertTrue(first.getString("queueName").length() > 0);
- Assert.assertEquals(queueName.toString(), first.getString("queueName"));
- Assert.assertEquals(false, first.getBoolean("browseOnly"));
- Assert.assertEquals(0,
first.getJsonNumber("deliveringCount").longValue());
+
Assert.assertTrue(first.getJsonNumber(ConsumerField.CREATION_TIME.getName()).longValue()
> 0);
+
Assert.assertNotNull(first.getJsonNumber(ConsumerField.ID.getAlternativeName()).longValue());
+
Assert.assertTrue(first.getString(ConsumerField.CONNECTION.getAlternativeName()).length()
> 0);
+ Assert.assertEquals(factory.getConnection().getID().toString(),
first.getString(ConsumerField.CONNECTION.getAlternativeName()));
+
Assert.assertTrue(first.getString(ConsumerField.SESSION.getAlternativeName()).length()
> 0);
+ Assert.assertEquals(((ClientSessionImpl) session).getName(),
first.getString(ConsumerField.SESSION.getAlternativeName()));
+
Assert.assertTrue(first.getString(ConsumerField.QUEUE.getAlternativeName()).length()
> 0);
+ Assert.assertEquals(queueName.toString(),
first.getString(ConsumerField.QUEUE.getAlternativeName()));
+ Assert.assertEquals(false,
first.getBoolean(ConsumerField.BROWSE_ONLY.getName()));
+ Assert.assertEquals(0,
first.getJsonNumber(ConsumerField.MESSAGES_IN_TRANSIT.getName()).longValue());
+ Assert.assertEquals(0,
first.getJsonNumber(ConsumerField.MESSAGES_IN_TRANSIT_SIZE.getName()).longValue());
+ Assert.assertEquals(0,
first.getJsonNumber(ConsumerField.MESSAGES_ACKNOWLEDGED.getName()).longValue());
+ Assert.assertEquals(0,
first.getJsonNumber(ConsumerField.LAST_DELIVERED_TIME.getName()).longValue());
+ Assert.assertEquals(0,
first.getJsonNumber(ConsumerField.LAST_ACKNOWLEDGED_TIME.getName()).longValue());
+
+
Assert.assertTrue(second.getJsonNumber(ConsumerField.CREATION_TIME.getName()).longValue()
> 0);
+
Assert.assertNotNull(second.getJsonNumber(ConsumerField.ID.getAlternativeName()).longValue());
+
Assert.assertTrue(second.getString(ConsumerField.CONNECTION.getAlternativeName()).length()
> 0);
+ Assert.assertEquals(factory2.getConnection().getID().toString(),
second.getString(ConsumerField.CONNECTION.getAlternativeName()));
+
Assert.assertTrue(second.getString(ConsumerField.SESSION.getAlternativeName()).length()
> 0);
+ Assert.assertEquals(((ClientSessionImpl) session2).getName(),
second.getString(ConsumerField.SESSION.getAlternativeName()));
+
Assert.assertTrue(second.getString(ConsumerField.QUEUE.getAlternativeName()).length()
> 0);
+ Assert.assertEquals(queueName.toString(),
second.getString(ConsumerField.QUEUE.getAlternativeName()));
+ Assert.assertEquals(false,
second.getBoolean(ConsumerField.BROWSE_ONLY.getName()));
+ Assert.assertEquals(0,
second.getJsonNumber(ConsumerField.MESSAGES_IN_TRANSIT.getName()).longValue());
+ Assert.assertEquals(0,
second.getJsonNumber(ConsumerField.MESSAGES_IN_TRANSIT_SIZE.getName()).longValue());
+ Assert.assertEquals(0,
second.getJsonNumber(ConsumerField.MESSAGES_ACKNOWLEDGED.getName()).longValue());
+ Assert.assertEquals(0,
second.getJsonNumber(ConsumerField.LAST_DELIVERED_TIME.getName()).longValue());
+ Assert.assertEquals(0,
second.getJsonNumber(ConsumerField.LAST_ACKNOWLEDGED_TIME.getName()).longValue());
- Assert.assertTrue(second.getJsonNumber("creationTime").longValue() > 0);
- Assert.assertNotNull(second.getJsonNumber("consumerID").longValue());
- Assert.assertTrue(second.getString("connectionID").length() > 0);
- Assert.assertEquals(factory2.getConnection().getID().toString(),
second.getString("connectionID"));
- Assert.assertTrue(second.getString("sessionID").length() > 0);
- Assert.assertEquals(((ClientSessionImpl) session2).getName(),
second.getString("sessionID"));
- Assert.assertTrue(second.getString("queueName").length() > 0);
- Assert.assertEquals(queueName.toString(), second.getString("queueName"));
- Assert.assertEquals(false, second.getBoolean("browseOnly"));
- Assert.assertEquals(0,
second.getJsonNumber("deliveringCount").longValue());
+ }
+
+
+ @Test
+ public void testListAllConsumersAsJSONTXCommit() throws Exception {
+ SimpleString queueName = new SimpleString(UUID.randomUUID().toString());
+ ActiveMQServerControl serverControl = createManagementControl();
+
+ ServerLocator locator = createInVMNonHALocator();
+ ClientSessionFactory factory = createSessionFactory(locator);
+ ClientSession session = factory.createSession(true,false, 1);
+ addClientSession(session);
+
+ serverControl.createAddress(queueName.toString(),
RoutingType.ANYCAST.name());
+ if (legacyCreateQueue) {
+ server.createQueue(queueName, RoutingType.ANYCAST, queueName, null,
false, false);
+ } else {
+ server.createQueue(new
QueueConfiguration(queueName).setRoutingType(RoutingType.ANYCAST).setDurable(false));
+ }
+
+ ClientConsumer consumer = session.createConsumer(queueName, null, 100,
-1, false);
+ addClientConsumer(consumer);
+ session.start();
+ Thread.sleep(200);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
