gemmellr commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261249473
##########
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/base/ClasspathBase.java:
##########
@@ -181,7 +179,15 @@ protected ClassLoader getClasspath(String name, boolean
forceNew) throws Excepti
classPathValue = buffer.toString();
}
- Assert.assertTrue("Cannot run compatibility tests, no classpath found on
./target/" + name + ".cp", classPathValue != null &&
!classPathValue.trim().equals(""));
+ boolean foundClassPath = classPathValue != null &&
!classPathValue.trim().equals("");
+
+ if (!foundClassPath) {
+ logger.info("Rebuild project with -Pcompatibility-tests. Cannot find
classpath definition for {}", name);
+ }
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests.",
foundClassPath);
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests to be able
to run this test. No classpath found on ./target/" + name + ".cp",
foundClassPath);
Review Comment:
Ok. Then I'll actually ask. I was confused why you changed the existing
assertion check to an Assume, which will skip rather than fail the test?
Originally it used an assertTrue that would fail if tripped, and then you had
tried to add an explicit fail here at first, but then switched it to the
[semi-duplicated] assumeTrue instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
