gemmellr commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261482609
##########
pom.xml:
##########
@@ -1276,7 +1276,6 @@
<skipJoramTests>false</skipJoramTests>
<skipIntegrationTests>false</skipIntegrationTests>
<skipIsolatedIntegrationTests>false</skipIsolatedIntegrationTests>
- <skipCompatibilityTests>false</skipCompatibilityTests>
Review Comment:
You left it set not-skipped/enabled in the fast-tests profile.
##########
pom.xml:
##########
@@ -1287,6 +1286,12 @@
<skipLeakTests>false</skipLeakTests>
</properties>
</profile>
+ <profile>
+ <id>compatibility-tests</id>
Review Comment:
Would prefer this profile was in the compatibility-tests module.
Well, it is already there...would prefer the property was redefined in the
module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
