gemmellr commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1262358988
##########
pom.xml:
##########
@@ -1287,6 +1286,12 @@
<skipLeakTests>false</skipLeakTests>
</properties>
</profile>
+ <profile>
+ <id>compatibility-tests</id>
Review Comment:
Those ones at least have the case of applying to lots of modules, and
setting the prop is often the only effect of the profile.
This one is entirely specific to compatibility-tests, which already has the
profile itself, which does more than just setting the prop, so it would seem
nicer if it was all together in the module. (You also just had to make 2 fixup
commits that were basically the result of splitting such prop updates).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
