clebertsuconic commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261295183
##########
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/base/ClasspathBase.java:
##########
@@ -181,7 +179,15 @@ protected ClassLoader getClasspath(String name, boolean
forceNew) throws Excepti
classPathValue = buffer.toString();
}
- Assert.assertTrue("Cannot run compatibility tests, no classpath found on
./target/" + name + ".cp", classPathValue != null &&
!classPathValue.trim().equals(""));
+ boolean foundClassPath = classPathValue != null &&
!classPathValue.trim().equals("");
+
+ if (!foundClassPath) {
+ logger.info("Rebuild project with -Pcompatibility-tests. Cannot find
classpath definition for {}", name);
+ }
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests.",
foundClassPath);
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests to be able
to run this test. No classpath found on ./target/" + name + ".cp",
foundClassPath);
Review Comment:
@gemmellr PR has what I intend to merge now (apart from having to remove the
DO-NOT-MERGE commit as I'm validating if the PR can handle the failure).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
