clebertsuconic commented on code in PR #4838:
URL: https://github.com/apache/activemq-artemis/pull/4838#discussion_r1509183207
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPFederationQueuePolicyTest.java:
##########
@@ -2782,6 +2785,8 @@ public void
testPullQueueConsumerBatchCreditTopUpAfterEachBacklogDrain() throws
.now();
}
+ Wait.assertTrue(() ->
server.queueQuery(queueName).getMessageCount() ==
DEFAULT_PULL_CREDIT_BATCH_SIZE);
Review Comment:
shouldn't it be >=?
Also, I have been using timeouts on all the assertEquals and assertTrues I
have been adding.
I have been procrastinating removing the default method and always requiring
a timeout set. as an eventual failure here would take 30seconds to happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
