clebertsuconic commented on code in PR #4838:
URL: https://github.com/apache/activemq-artemis/pull/4838#discussion_r1509194240
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPFederationQueuePolicyTest.java:
##########
@@ -2782,6 +2785,8 @@ public void
testPullQueueConsumerBatchCreditTopUpAfterEachBacklogDrain() throws
.now();
}
+ Wait.assertTrue(() ->
server.queueQuery(queueName).getMessageCount() ==
DEFAULT_PULL_CREDIT_BATCH_SIZE);
Review Comment:
@tabish121 ok.. I assumed the test was sending more messages than that.. (I
hadn't fully read the test :) )
I would recommend the timeout though.... but that's optional.. as if I / we
ever move the default method that would be done as part of the whole batch at
the point.
other than that.. it LGTM... merge it whenever you want it. (so I will let
you decide if you are using the timeout or not).
```
Wait.assertTrue(() -> server.queueQuery(queueName).getMessageCount() ==
DEFAULT_PULL_CREDIT_BATCH_SIZE, 5000);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
