tabish121 commented on code in PR #4838:
URL: https://github.com/apache/activemq-artemis/pull/4838#discussion_r1509206469
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPFederationQueuePolicyTest.java:
##########
@@ -2782,6 +2785,8 @@ public void
testPullQueueConsumerBatchCreditTopUpAfterEachBacklogDrain() throws
.now();
}
+ Wait.assertTrue(() ->
server.queueQuery(queueName).getMessageCount() ==
DEFAULT_PULL_CREDIT_BATCH_SIZE);
Review Comment:
Setting a different timeout assumes one can guess how slow / fast the CI
machine is which seems tough given the failures I've been seeing. Personally I
tend to be more concerned with the lengthy amount of time it takes to run the
existing tests that do pass rather than the occasional failures due to timeout.
I'd recommend lowering the default timeout value if that is of a major
concern, drop it to 5 or 10 seconds as a baseline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
