clebertsuconic commented on code in PR #4838:
URL: https://github.com/apache/activemq-artemis/pull/4838#discussion_r1509216257


##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPFederationQueuePolicyTest.java:
##########
@@ -2782,6 +2785,8 @@ public void 
testPullQueueConsumerBatchCreditTopUpAfterEachBacklogDrain() throws
                                     .now();
             }
 
+            Wait.assertTrue(() -> 
server.queueQuery(queueName).getMessageCount() == 
DEFAULT_PULL_CREDIT_BATCH_SIZE);

Review Comment:
   @tabish121 I tried that and it wasn't simple for some reason I don't 
remember now.. I think some tests were failing. 
   
   I talked to Robbie about that and we thought about removing the default 
timeout method.
   
   
   this is a different discussion of course.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to