jbonofre commented on code in PR #1222:
URL: https://github.com/apache/activemq/pull/1222#discussion_r1598115243
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2048,7 +2047,7 @@ protected void checkTmpStoreUsageLimits() throws
Exception {
long maxJournalFileSize;
PListStore store = usage.getTempUsage().getStore();
- if (store != null && store instanceof JournaledStore) {
+ if (store instanceof JournaledStore) {
Review Comment:
Same here, `store` can be `null` if temp usage is not set.
##########
activemq-broker/README.md:
##########
@@ -0,0 +1,6 @@
+## Description
Review Comment:
I'm not a big fan of having `README.md` in a module. It can lead to
scattered the information in different place.
I would rather update the `README.md` at root level. We can eventually add a
`CONTRIBUTING.md` file dedicate to contribution.
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -831,10 +832,8 @@ public void stop() throws Exception {
this.scheduler.stop();
this.scheduler = null;
}
- if (services != null) {
- for (Service service : services) {
- stopper.stop(service);
- }
+ for (Service service : services) {
Review Comment:
I think we should still check if `services` is not `null` as it can be
passed programmatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
