mattrpav commented on code in PR #1222:
URL: https://github.com/apache/activemq/pull/1222#discussion_r1598606829
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -1768,7 +1767,7 @@ public synchronized PListStore getTempDataStore() {
try {
PersistenceAdapter pa = getPersistenceAdapter();
- if( pa!=null && pa instanceof PListStore) {
+ if(pa instanceof PListStore) {
Review Comment:
Why is the null check being removed?
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -286,7 +286,8 @@ public class BrokerService implements Service {
LOG.info("Loaded the Bouncy Castle security provider at
position: {}", ret);
}
} catch(Throwable e) {
- // No BouncyCastle found so we use the default Java Security
Provider
+ // No BouncyCastle found, so we use the default Java Security
Provider
+ LOG.info("Using the default Java security provider");
Review Comment:
Does this need to be printed out on every startup? Perhaps this is debug
level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
