kenliao94 commented on code in PR #1222:
URL: https://github.com/apache/activemq/pull/1222#discussion_r1598758044
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -1768,7 +1767,7 @@ public synchronized PListStore getTempDataStore() {
try {
PersistenceAdapter pa = getPersistenceAdapter();
- if( pa!=null && pa instanceof PListStore) {
+ if(pa instanceof PListStore) {
Review Comment:
Because `instanceof` already handles null checking. I.E if pa == null,
instanceof will return false. So In this case, I believe the null checking is
redundant. Do you see any concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
