kenliao94 commented on code in PR #1222:
URL: https://github.com/apache/activemq/pull/1222#discussion_r1598126867
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -831,10 +832,8 @@ public void stop() throws Exception {
this.scheduler.stop();
this.scheduler = null;
}
- if (services != null) {
- for (Service service : services) {
- stopper.stop(service);
- }
+ for (Service service : services) {
Review Comment:
Interesting, because services is marked as final when it's instantiated in
line 180. So services should never be null. Am I read the code correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
