gemmellr commented on code in PR #5451:
URL: https://github.com/apache/activemq-artemis/pull/5451#discussion_r1923743956
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java:
##########
@@ -76,7 +76,7 @@ public static SyncDataType getDataType(byte code) {
public ReplicationStartSyncMessage(boolean beforeTwoEighteen) {
super(REPLICATION_START_FINISH_SYNC);
- this.beforeTwoEighteen = synchronizationIsFinished;
+ this.beforeTwoEighteen = beforeTwoEighteen;
Review Comment:
If _this.beforeTwoEighteen_ was always being set false before, due to the
_synchronizationIsFinished_ field being false at this point, what are the
implications of changing this now such that it might now become true?
This seems to point to a test either not existing or not actually being
effective in checking this, or perhaps just not actually needing this/related
code if it never actually did anything. It doesnt seem like this change should
be happening without some other matching change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
