gemmellr commented on code in PR #5451:
URL: https://github.com/apache/activemq-artemis/pull/5451#discussion_r1925700321
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java:
##########
@@ -76,7 +76,7 @@ public static SyncDataType getDataType(byte code) {
public ReplicationStartSyncMessage(boolean beforeTwoEighteen) {
super(REPLICATION_START_FINISH_SYNC);
- this.beforeTwoEighteen = synchronizationIsFinished;
+ this.beforeTwoEighteen = beforeTwoEighteen;
Review Comment:
The original original PR and email discussion had suggested there was an
issue with the newer servers sending the additional data to the old broker, but
it would certainly seem like thats what it has always continued doing even
after the subsequent PR was applied, suggesting that isnt the case (or that in
the end noone hit it again).
In general I do think it makes more sense to prevent sending such new data
to old brokers when making such changes, but it would appear that has always
been the case here, so if it hasnt caused issue then at this stage years later
perhaps just removing the gating check is the way to go at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
