jbertram commented on code in PR #5451:
URL: https://github.com/apache/activemq-artemis/pull/5451#discussion_r1924303411
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java:
##########
@@ -76,7 +76,7 @@ public static SyncDataType getDataType(byte code) {
public ReplicationStartSyncMessage(boolean beforeTwoEighteen) {
super(REPLICATION_START_FINISH_SYNC);
- this.beforeTwoEighteen = synchronizationIsFinished;
+ this.beforeTwoEighteen = beforeTwoEighteen;
Review Comment:
The main fix for the original issue (i.e. ARTEMIS-3767) was in
`ReplicationAddMessage` and `ReplicationAddTXMessage`. The only important part
of the fix in `ReplicationStartSyncMessage` is in `decodeRest` where versions
before 2.18.0 will send less data than newer versions. The `beforeTwoEighteen`
variable is not actually needed because sending _more_ data to an older version
is not a problem. The older version will simply ignore it. I'm updating the fix
to take this into account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
