jbertram commented on code in PR #5451: URL: https://github.com/apache/activemq-artemis/pull/5451#discussion_r1925733494
########## artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationStartSyncMessage.java: ########## @@ -76,7 +76,7 @@ public static SyncDataType getDataType(byte code) { public ReplicationStartSyncMessage(boolean beforeTwoEighteen) { super(REPLICATION_START_FINISH_SYNC); - this.beforeTwoEighteen = synchronizationIsFinished; + this.beforeTwoEighteen = beforeTwoEighteen; Review Comment: As I understand it, the problem wasn't so much that the newer server was sending _additional_ data so much as it was sending _different_ data that the older server was choking on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact