cshannon commented on PR #1377: URL: https://github.com/apache/activemq/pull/1377#issuecomment-2611230540
I only started looking at this but one thing I wanted to point out that could be changed as part of this and something I missed before when #1258 was done.... instead of having a position counter and having to scan through couldn't you just set the batch for recovery at the offset location? Also, the offset should probably be a long and not an int because long is used by the order index. I haven't tested it super well other than running the KahaDBOffsetRecoveryListenerTest, but here is an example against the main branch of what I mean: https://github.com/cshannon/activemq/commit/648a580c2134209280a7b6dccd24fb718ee8457f The other impls (temp kaha, memory) may be able to be changed too, not sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For additional commands, e-mail: gitbox-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
