cshannon commented on code in PR #1377:
URL: https://github.com/apache/activemq/pull/1377#discussion_r1927911075
##########
activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/KahaDBStore.java:
##########
@@ -766,6 +773,83 @@ public void execute(Transaction tx) throws Exception {
}
}
sd.orderIndex.stoppedIterating();
+
+ if(revertOrderIndex && position > 0) {
+ sd.orderIndex.resetCursorPosition();
Review Comment:
This does not revert the index to the previous location, it reverts it to 0
at the beginning. One way to avoid having side effects and having to reset at
all is to create a different MessageOrderCursor and not the internal one as
that tracks state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
