cshannon commented on code in PR #1377:
URL: https://github.com/apache/activemq/pull/1377#discussion_r1927854541
##########
activemq-console/src/main/java/org/apache/activemq/console/command/store/StoreBackup.java:
##########
@@ -88,6 +97,14 @@ public void execute() throws Exception {
throw new Exception("optional --offset and --count must be
specified together");
}
+ if ((startMsgId != null || endMsgId != null) && queue == null) {
+ throw new Exception("optional --queue must be specified when using
startMsgId or endMsgId");
+ }
+
+ if (indexes != null && !indexes.isBlank()) {
+ indexesList = parseIndexesParam(indexes);
Review Comment:
```suggestion
ndexesList = Stream.of(indexes.split(",")).map(index ->
Integer.parseInt(index.trim())).collect(Collectors.toList());
```
##########
activemq-console/src/main/java/org/apache/activemq/console/command/store/StoreBackup.java:
##########
@@ -88,6 +97,14 @@ public void execute() throws Exception {
throw new Exception("optional --offset and --count must be
specified together");
}
+ if ((startMsgId != null || endMsgId != null) && queue == null) {
+ throw new Exception("optional --queue must be specified when using
startMsgId or endMsgId");
+ }
+
+ if (indexes != null && !indexes.isBlank()) {
+ indexesList = parseIndexesParam(indexes);
Review Comment:
```suggestion
indexesList = Stream.of(indexes.split(",")).map(index ->
Integer.parseInt(index.trim())).collect(Collectors.toList());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
