cshannon commented on PR #1377:
URL: https://github.com/apache/activemq/pull/1377#issuecomment-2616923918
> > static class MessageRecoveryConfig {
> > final String startMsgId;
> > ...
>
> I was thinking a MessageRecoveryContext would make sense where it could be
an extension of the listener w/ config options.
>
> Then the method could take one parameter: MessageRecoveryContext ..
>
> ```
> static class MessageRecoveryContext {
>
> final MessageRecoveryListener listener;
> final long offset;
> final String startMsgId ..
> ```
>
> However, this also introduces complexity of deciding which fields to use..
the offset+maxRecovered and/or the startMsgId and/or the endMsgId.. etc.
Yeah, you have to get into validation in that case. Really the question is
do you plan to keep expanding the features? I don't think we want to get into a
situation where we have 20 different overloaded methods with different argument
combinations. The more flags we have the better it is to just make some sort of
configuration type object and then just validate the flag combinations that are
set are correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
