gemmellr commented on code in PR #5455:
URL: https://github.com/apache/activemq-artemis/pull/5455#discussion_r1930885209
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java:
##########
@@ -327,6 +327,9 @@ public String[] getStaticNodes() {
@Option(names = "--jdbc-lock-expiration", description = "Lock expiration
(in milliseconds).")
long jdbcLockExpiration =
ActiveMQDefaultConfiguration.getDefaultJdbcLockExpirationMillis();
+ @Option(names = "--journal-max-aio", description = "The journal-max-io
value to use when also using the ASYNCIO journal-type. When using NIO or MAPPED
this value is always '1'. Default: 4096")
Review Comment:
Yeah, I think `journal-max-io-aio` would be fine. I think I'd at least try
to make those two use cases align if possible, if it it is not just going to be
using --journal-max-io to match the xml (which I also think would be fine, I
dont think its any more confusing than the XML element always being named and
being present even if its not doing anything; the CLI description makes clear
enough when the option applies, and it wont have any effect in non-applicable
cases regardless what it is named).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
