gemmellr commented on code in PR #5455:
URL: https://github.com/apache/activemq-artemis/pull/5455#discussion_r1937290481
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java:
##########
@@ -298,6 +298,9 @@ public String[] getStaticNodes() {
@Option(names = "--security-manager", description = "Which security manager
to use - jaas or basic. Default: jaas.")
private String securityManager = "jaas";
+ @Option(names = "--journal-max-io", description = "The journal-max-io value
to use when also using the ASYNCIO journal-type. When using NIO or MAPPED this
value is always '1'. Default: 4096")
+ private long journalMaxIo =
ActiveMQDefaultConfiguration.getDefaultJournalMaxIoAio();
Review Comment:
I just twigged with your most recent updates that this is a long...which on
reflection seemed a bit large given the default, and this option being added
because that is actually _too big_ in some envs.
On checking, journal-max-io is also defined as an _int_ for all the rest of
the configuration bits, so this should match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
