gemmellr commented on code in PR #5455:
URL: https://github.com/apache/activemq-artemis/pull/5455#discussion_r1931969085
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java:
##########
@@ -327,6 +327,9 @@ public String[] getStaticNodes() {
@Option(names = "--jdbc-lock-expiration", description = "Lock expiration
(in milliseconds).")
long jdbcLockExpiration =
ActiveMQDefaultConfiguration.getDefaultJdbcLockExpirationMillis();
+ @Option(names = "--journal-max-aio", description = "The journal-max-io
value to use when also using the ASYNCIO journal-type. When using NIO or MAPPED
this value is always '1'. Default: 4096")
Review Comment:
It is a little redundant, but also more consistent and less likely to
confuse.
For me --journal-max-aio is a bit _off_ because it is so similar to, but
still not the same as, the actual journal-max-io XML element setting it is
actually for controlling. I expect that would trip some folks up, both in
finding it, and in using it. I would just use --journal-max-io in preference to
--journal-max-aio personally. The different ways of configuring journal-max-io
would then at least all include journal-max-io in their naming in some form,
either partially or as the whole name.
If we use journal-max-aio we will then have 3 different names for
configuration for the same thing, one of which doesnt even contain the name
journal-max-io despite directly existing to govern that XML element.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
