clebertsuconic commented on code in PR #5455:
URL: https://github.com/apache/activemq-artemis/pull/5455#discussion_r1932679219
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java:
##########
@@ -327,6 +327,9 @@ public String[] getStaticNodes() {
@Option(names = "--jdbc-lock-expiration", description = "Lock expiration
(in milliseconds).")
long jdbcLockExpiration =
ActiveMQDefaultConfiguration.getDefaultJdbcLockExpirationMillis();
+ @Option(names = "--journal-max-aio", description = "The journal-max-io
value to use when also using the ASYNCIO journal-type. When using NIO or MAPPED
this value is always '1'. Default: 4096")
Review Comment:
I don't think there's a direct reference between the Create command and
their XML elements... these are distinct namespaces to me.
--journal-max-io-aio won't make it much better... if we are concerned we
would have to find a totally different name such as --journal-limit-aio...
i think --journal-max-aio for this case is fine.. since there are no other
similar parameters on the Create
that's my opinion on this, but I'm not strong opinionated ... if you guys
want to go against what I think... I wouldn't fight over :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
