gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1932539068
##########
artemis-commons/src/test/java/org/apache/activemq/artemis/utils/collections/LongHashSetTest.java:
##########
@@ -327,7 +326,7 @@ public void containsEmptySet() {
final LongHashSet other = new LongHashSet(100);
assertTrue(testSet.containsAll(other));
- assertTrue(testSet.containsAll((Collection<?>) other));
+ assertTrue(testSet.containsAll(other));
Review Comment:
These aren't redundant casts. The class has its own containsAll(LongHashSet)
but really has 2 methods as it also inherits containsAll(Collection) (unclear
if it shouldnt be overriding it).
Notice all the changed lines result in duplicate assertions; this cast is
the test trying to force which method is used in order to check both methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
