gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1932607258


##########
tests/db-tests/src/test/java/org/apache/activemq/artemis/tests/db/paging/PagingTest.java:
##########
@@ -424,8 +425,6 @@ public void testSimpleCursorIteratorLargeMessage() throws 
Exception {
       server = createServer(true, config, PAGE_SIZE, PAGE_MAX);
       server.start();
 
-      final int numberOfBytes = 200 * 1024;

Review Comment:
   The method says it is for testing LargeMessage, yet it isnt using the 
numberOfBytes variable, and doesnt obliviously appear to be using large 
messages.
   
   Rather than needing removal, this seems more like its indicating a test bug 
that needs fixed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to