gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1932628837
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/BackupSyncJournalTest.java:
##########
@@ -154,14 +154,9 @@ public void testReserveFileIdValuesOnBackup() throws
Exception {
assertEquals(size, backupMsgJournal.getFileSize(), "file sizes must be
the same");
Set<Pair<Long, Integer>> backupIds = getFileIds(backupMsgJournal);
-
- int total = 0;
for (Pair<Long, Integer> pair : primaryIds) {
- total += pair.getB();
Review Comment:
Not sure we need empty loop this leaves, both here and the similar one that
follows immediately.
I would instead wonder what they originally existed to do and whether the
test simply isnt/wasnt checking something that it was actually meant to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
