gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1932590511
##########
tests/activemq5-unit-tests/src/test/java/org/apache/activemq/openwire/v1/ActiveMQBytesMessageTest.java:
##########
@@ -40,7 +40,6 @@ public Object createObject() throws Exception {
@Override
protected void populateObject(Object object) throws Exception {
super.populateObject(object);
- ActiveMQBytesMessage info = (ActiveMQBytesMessage) object;
Review Comment:
This removal then also renders the entire method superflous since all it
does is call super.
I'd either leave it as it is, since these are originally generated files
from ported tests (so the more we change them, the further from the originals
they go)...or delete the methods instead of just the variable.
Same goes for the likely tens of other similar cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
