gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934094334


##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/brokerConnection/MirrorInfiniteRetryReplicaTest.java:
##########
@@ -153,18 +153,18 @@ private static void createMirroredServer(String 
serverName,
 
    private static void replaceLogs(File serverLocation) throws Exception {
       File log4j = new File(serverLocation, "/etc/log4j2.properties");
-      assertTrue(FileUtil.findReplace(log4j, "logger.artemis_utils.level=INFO",
-                                      "logger.artemis_utils.level=INFO\n" + 
"\n" +
-                                      
"logger.endpoint.name=org.apache.activemq.artemis.core.replication.ReplicationEndpoint\n"
 +
-                                      "logger.endpoint.level=DEBUG\n" +
-                                      
"logger.ackmanager.name=org.apache.activemq.artemis.protocol.amqp.connect.mirror.AckManager\n"
 +
-                                      "logger.ackmanager.level=INFO\n" +
-
-                                      
"logger.mirrorTarget.name=org.apache.activemq.artemis.protocol.amqp.connect.mirror.AMQPMirrorControllerTarget\n"
 +
-                                      "logger.mirrorTarget.level=INFO\n" +
-
-                                      "appender.console.filter.threshold.type 
= ThresholdFilter\n" +
-                                      "appender.console.filter.threshold.level 
= trace"));
+      assertTrue(FileUtil.findReplace(log4j, 
"logger.artemis_utils.level=INFO", """
+         logger.artemis_utils.level=INFO
+
+         
logger.endpoint.name=org.apache.activemq.artemis.core.replication.ReplicationEndpoint
+         logger.endpoint.level=DEBUG
+         
logger.ackmanager.name=org.apache.activemq.artemis.protocol.amqp.connect.mirror.AckManager
+         logger.ackmanager.level=INFO
+         
logger.mirrorTarget.name=org.apache.activemq.artemis.protocol.amqp.connect.mirror.AMQPMirrorControllerTarget
+         logger.mirrorTarget.level=INFO
+         appender.console.filter.threshold.type = ThresholdFilter
+         appender.console.filter.threshold.level = trace\
+         """));

Review Comment:
   Possibly simpler to add the close deliminator on the same line than use line 
ending suppression?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to